lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 29 Nov 2013 21:29:37 +0100 From: Linus Walleij <linus.walleij@...aro.org> To: Jonas Jensen <jonas.jensen@...il.com> Cc: "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, Grant Likely <grant.likely@...aro.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "arm@...nel.org" <arm@...nel.org>, Arnd Bergmann <arnd@...db.de>, Mark Rutland <mark.rutland@....com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org> Subject: Re: [PATCH v7] gpio: Add MOXA ART GPIO driver On Fri, Nov 29, 2013 at 12:11 PM, Jonas Jensen <jonas.jensen@...il.com> wrote: > Add GPIO driver for MOXA ART SoCs. > > Signed-off-by: Jonas Jensen <jonas.jensen@...il.com> OK this v6 version is looking *really good* so I have applied it, couldn't hesitate. > +static struct gpio_chip moxart_template_chip = { > + .label = "moxart-gpio", > + .request = moxart_gpio_request, > + .free = moxart_gpio_free, > + .direction_input = moxart_gpio_direction_input, > + .direction_output = moxart_gpio_direction_output, > + .set = moxart_gpio_set, > + .get = moxart_gpio_get, > + .base = 0, > + .ngpio = 32, > + .can_sleep = 0, > +}; No need to initialized unused fields to zero, that is by default. But no big deal. > +static const struct of_device_id moxart_gpio_match[] = { > + { .compatible = "moxa,moxart-gpio" }, > + { } > +}; This vendor prefix does not exist in Documentation/devicetree/bindings/vendor-prefixes.txt Please send a follow-up patch adding it and I can merge that through the GPIO tree as well. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists