linux-kernel - Re: Q: use vlan in container

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Nov 2013 14:40:13 +0800
From:	Libo Chen <clbchenlibo.chen@...wei.com>
To:	Serge Hallyn <serge.hallyn@...ntu.com>
CC:	<containers@...ts.linux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, <gaofeng@...fujitsu.com>,
	David Miller <davem@...emloft.net>,
	Li Zefan <lizefan@...wei.com>,
	Huang Qiang <h.huangqiang@...wei.com>,
	Wengmeiling <wengmeiling.weng@...wei.com>,
	"zhangwei(Jovi)" <jovi.zhangwei@...wei.com>
Subject: Re: Q: use vlan in container

On 2013/11/29 13:05, Serge Hallyn wrote:
> Quoting Libo Chen (clbchenlibo.chen@...wei.com):
>> Hello LXC experts,
>>
>> 	I meet a problem. When using vlan as network device in suse11 system container,
>> I can not use halt to stop this container. It hung on "eth0 is still used from interfaces eth0" in cycle.
>>
>> The config file:
>>
>> lxc.network.type = vlan
>> lxc.network.flags = up
>> lxc.network.link = eth0
>> lxc.network.name = eth0
>> lxc.network.vlan.id = 1301
>> lxc.network.ipv4 = 128.5.131.100/24
>>
>>
>> The reason is in the shell command /sbin/ifdown, see below:
>>
>> ######################################################################
>> # Shut down depending interfaces
>> #
>> # Check if there are interfaces which depend on this interface. If yes these
>> # have to be shut down first.
>> # For example these might be bonding or vlan interfaces. Note that we don't
>> # catch all types of depending interfaces currently. See function
>> # 'get_depending_ifaces' in file 'functions' for details.
>> #
>> test "$SCRIPTNAME" = ifdown && DEP_IFACES=`get_depending_ifaces $INTERFACE`
>> if [ "$?" = 0 -a "$NODEPS" != yes ] ; then
>>         message "`printf "    %-9s is still used from interfaces %s" \
>>                          $INTERFACE "$DEP_IFACES"`"
>>         for DI in $DEP_IFACES; do
> 
> Should the proper fix be to fix this script so that it doesn't call
> ifdown recursively if $DI = $INTERFACE ?

Hi Serge,

yes, I had try this way before as below:

        for DI in $DEP_IFACES; do
	         if [ "$DI" != "$INTERFACE" ] ; then
                       ifdown $DI -o $OPTIONS
	         fi
        done

It works well, but I have no idea it is safe enough and no side effects?

Thanks,
Libo

> 
>>                 ifdown $DI -o $OPTIONS
>>         done
>>
>>         message "`printf "    %-9s now going down itself" $INTERFACE`"
>>         # check if iface is (still) avaliable
>>         # [bonding master may go down itself
>>         #  while the last slave gets removed]
>>         if ! is_iface_available $INTERFACE; then
>>                 exit $R_SUCCESS
>>         fi
>> fi
>>
>>
>> $DEP_IFACES is also eth0 in this scene, so ifdown will call ifdown again and again.
>>
>> if we set lxc.network.name = eth1, it will be ok, so can we add a judgment to make
>> lxc.network.link and lxc.network.name are not equal in lxc-start command.
>>
>> simple implement like:
>>
>> 	if [ lxc.network.type == vlan ] ; then
>> 		if [ lxc.network.link == lxc.network.name ] ; then
>> 			return false
>> 		fi
>> 	fi
>>
>>
>> Is it reasonable?  or any other way to achieve this?
>>
>>
>>
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/