linux-kernel - Re: HID: kye: Add report fixup for Genius Manticore Keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131130214211.GA16854@redhat.com>
Date:	Sat, 30 Nov 2013 16:42:11 -0500
From:	Dave Jones <davej@...hat.com>
To:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc:	Benjamin Tissoires <benjamin.tissoires@...hat.com>,
	Jiri Kosina <jkosina@...e.cz>
Subject: Re: HID: kye: Add report fixup for Genius Manticore Keyboard

 > Commit:     4a2c94c9b6c03af61b04993340bd9559e2277de4
 > Author:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
 > AuthorDate: Wed Nov 20 09:49:41 2013 -0500
 > Committer:  Jiri Kosina <jkosina@...e.cz>
 > CommitDate: Thu Nov 21 10:28:58 2013 +0100
 > 
 >     HID: kye: Add report fixup for Genius Manticore Keyboard
 >     
 >     Genius Manticore Keyboard presents the same problem in its report
 >     descriptors than Genius Gila Gaming Mouse and Genius Imperator Keyboard.
 >     Use the same fixup.

..

 > diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c
 > index 7384512..35a4f9c 100644
 > --- a/drivers/hid/hid-kye.c
 > +++ b/drivers/hid/hid-kye.c
 > @@ -341,6 +341,9 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc,
 >  	case USB_DEVICE_ID_GENIUS_GX_IMPERATOR:
 >  		rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83,
 >  					"Genius Gx Imperator Keyboard");
 > +	case USB_DEVICE_ID_GENIUS_MANTICORE:
 > +		rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104,
 > +					"Genius Manticore Keyboard");
 >  		break;


Is the IMPERATOR case supposed to fall-through to MANTICORE here, or is there a missing break ?
The commit text describes using the same fixup, but has this alternative case.

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/