linux-kernel - Re: [PATCH v3 1/2] power_supply: Fix Oops from NULL pointer dereference from wakeup_source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131201215012.GA6271@lizard>
Date:	Sun, 1 Dec 2013 13:50:13 -0800
From:	Anton Vorontsov <anton@...msg.org>
To:	Shuah Khan <shuah.kh@...sung.com>
Cc:	dwmw2@...radead.org, rostedt@...dmis.org, fweisbec@...il.com,
	mingo@...hat.com, rjw@...ysocki.net, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org, shuahkhan@...il.com,
	stable@...r.kernel.org
Subject: Re: [PATCH v3 1/2] power_supply: Fix Oops from NULL pointer
 dereference from wakeup_source_activate

On Fri, Nov 22, 2013 at 10:54:28AM -0700, Shuah Khan wrote:
> power_supply_register() calls device_init_wakeup() to register a wakeup
> source before initializing dev_name. As a result, device_wakeup_enable()
> end up registering wakeup source with a null name when wakeup_source_register()
> gets called with dev_name(dev) which is null at the time.
> 
> When kernel is booted with wakeup_source_activate enabled, it will panic
> when the trace point code tries to dereference ws->name.
> 
> Fixed the problem by moving up the kobject_set_name() call prior to accesses
> to dev_name(). Replaced kobject_set_name() with dev_set_name() which is the
> right interface to be called from drivers. Fixed the call to device_del() prior
> to device_add() in for wakeup_init_failed error handling code.

Applied, thanks a lot!

Anton
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/