[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1385891913.11457.2.camel@Nokia-N900>
Date: Sun, 01 Dec 2013 11:58:33 +0200
From: Ивайло Димитров
<ivo.g.dimitrov.75@...il.com>
To: Pali Rohá <pali.rohar@...il.com>,
Pavel Machek <pavel@....cz>
Cc: Greg KH <gregkh@...uxfoundation.org>,
Dan Carpenter <dan.carpenter@...cle.com>,
Ивайло Д
<freemangordon@....bg>, sre@...g0.de, omar.ramirez@...itl.com,
tony@...mide.com, felipe.contreras@...il.com, s-anna@...com,
nm@...com, ohad@...ery.com, stable@...r.kernel.org,
linux-kernel@...r.kernel.org, nico@...lde.de
Subject: Re: [patch] Staging: tidspbridge: make mmap root-only so it is not
a security problem
I can (and will) test whatever patches is needed. Also will try to get rid of uuid helpers and send a patch today.
On Sun Dec 1 11:41:39 2013 Pali Rohár <pali.rohar@...il.com> wrote:
> On Saturday 30 November 2013 23:58:23 Pavel Machek wrote:
> > On Sat 2013-11-30 14:05:53, Greg KH wrote:
> > > On Sat, Nov 30, 2013 at 09:42:37PM +0100, Pavel Machek wrote:
> > > > mmap in tidspbridge is missing range-checks. For now, make
> > > > this interface root-only, so that it does not cause
> > > > security problems.
> > >
> > > Please fix this properly and don't paper over the real
> > > problem here.
> >
> > Well, if the driver is left uncompilable, I'm pretty sure it
> > will bitrot.
> >
>
> If you want to compile tidspbridge driver, you need this patch:
> https://gitorious.org/linux-n900/linux-n900/commit/b9adde42d5351467fa9d281190213bb652499577
>
> Removing BROKEN is not enough.
>
> > I do have the hardware, but I'm pretty sure current mailine
> > does not have enough support to boot Maemo, so it is non
> > trivial for me to test changes here.
> >
>
> Use linux-n900 tree, there are patches also for tidspbridge
> driver, so old maemo and new harmattan userspace can use it. But
> HD videos not working yet (due to another problem, search for
> OMAPFB: CMA allocation failures).
>
> --
> Pali Rohár
> pali.rohar@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists