linux-kernel - Re: [PATCH v2 2/2] rtc: add hym8563 rtc-driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <201312011819.26005.heiko@sntech.de>
Date:	Sun, 1 Dec 2013 18:19:25 +0100
From:	Heiko Stübner <heiko@...ech.de>
To:	Richard Weinberger <richard.weinberger@...il.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	devicetree@...r.kernel.org, Grant Likely <grant.likely@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>, rtc-linux@...glegroups.com,
	Mike Turquette <mturquette@...aro.org>
Subject: Re: [PATCH v2 2/2] rtc: add hym8563 rtc-driver

Am Sonntag, 1. Dezember 2013, 15:38:40 schrieb Richard Weinberger:
> On Sun, Dec 1, 2013 at 2:39 PM, Heiko Stübner <heiko@...ech.de> wrote:
> > +static int hym8563_probe(struct i2c_client *client,
> > +                        const struct i2c_device_id *id)
> > +{
> > +       struct hym8563 *hym8563;
> > +       int ret, gpio_int;
> > +
> > +       hym8563 = devm_kzalloc(&client->dev, sizeof(hym8563),
> > GFP_KERNEL);
> 
> Shouldn't this be sizeof(*hym8563)?

you're right of course, thanks for catching the missing "*", I'll send a v3 
shortly.


Heiko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/