linux-kernel - Re: [REGRESSION][v3.4-rc1] PCI: add a PCI resource reallocation config option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Dec 2013 16:38:44 -0500
From:	Joseph Salisbury <joseph.salisbury@...onical.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Tim Gardner <tim.gardner@...onical.com>
Subject: Re: [REGRESSION][v3.4-rc1] PCI: add a PCI resource reallocation config
 option

On 11/28/2013 02:17 AM, Yinghai Lu wrote:
> On Wed, Nov 27, 2013 at 12:22 PM, Joseph Salisbury
> <joseph.salisbury@...onical.com> wrote:
>> Hi Yinghai,
>>
>> A kernel bug was opened against Ubuntu [0].  After a kernel bisect, it
>> was found that the following commit introduced the bug:
>>
>> commit b07f2ebc109b607789f648dedcff4b125f9afec6
>> Author: Yinghai Lu <yinghai@...nel.org>
>> Date:   Thu Feb 23 19:23:32 2012 -0800
>>
>>     PCI: add a PCI resource reallocation config option
>>
>>
>>
>> The regression was introduced as of v3.4-rc1 and also exists in current
>> mainline.
>>
>> The bug seems platform specific since we have not had allot of other
>> reports.  The bug is preventing ixgbe to probe Intel x520 NIC's.
>>
>> It would be easy enough to disable the PCI_REALLOC_ENABLE_AUTO config
>> option, but I wanted to get your feedback since you are the author.  It
>> looks like the bug reporter may also be able to work around the problem
>> with the pci=realloc=.
> The bios has problem to have two functions rom bar to same place, and
> root bus does
> not enough mmio range and confuse realloc logic.
>
> Please try attached patches to top of linus's tree, or your internal tree.
>
> Thanks
>
> Yinghai

Hi Yinghai,

Your patches were tested against the 3.5 tree.  The patches did fix the
bug, and allowed the Intel x520 NIC's to work properly.  We were unable
to test this with Linus' tree due to another bug, which prevents the
system from booting.  We are looking deeper into that bug and should be
able to test the mainline tree at some point.

Testing against the 3.5 tree required that I cherry-pick the following
commits: ff35147, 55ed83a, 967260c and 223d96f.  However, that shouldn't
affect the test results of your patches.

Thanks for your assistance with this!


Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/