linux-kernel - Re: [PATCH 07/39] edac: remove DEFINE_PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <003d01ceefb7$356b6f50$a0424df0$%han@samsung.com>
Date:	Tue, 03 Dec 2013 08:35:39 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Borislav Petkov' <bp@...en8.de>
Cc:	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org,
	'Doug Thompson' <dougthompson@...ssion.com>,
	linux-edac@...r.kernel.org, 'Jingoo Han' <jg1.han@...sung.com>,
	'Joe Perches' <joe@...ches.com>,
	'Bjorn Helgaas' <bhelgaas@...gle.com>
Subject: Re: [PATCH 07/39] edac: remove DEFINE_PCI_DEVICE_TABLE macro

On Tuesday, December 03, 2013 8:21 AM, Borislav Petkov wrote:
> On Tue, Dec 03, 2013 at 08:07:57AM +0900, Jingoo Han wrote:
> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> > is not preferred.
> 
> Says who and why?
> 
> The author of the commit message (that is you) should explain to the
> onlooker (that is me) why this patch needs to be applied.

(+cc Joe Perches, Bjorn Helgaas)

Hi Borislav Petkov,

According to the Greg Kroah-Hartman, 
"Yeah, and it's a horrid macro that deserves to be removed,
please don't use it in more places."

Currently, there is no other bus that has something like this
macro for their device ids. Thus, DEFINE_PCI_DEVICE_TABLE macro
should be removed.

I hope that these patches will be merged through Greg Kroah-Hartman's
'driver-core.git', with 'Acked-by' of each subsystem maintainer.

Best regards,
Jingoo Han

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/