linux-kernel - Re: [PATCH] ARM: at91: add usart3 alias to dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Dec 2013 12:36:39 +0100
From:	boris brezillon <b.brezillon@...rkiz.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>,
	linux-arm-kernel@...ts.infradead.org
CC:	linux-kernel@...r.kernel.org, jiri.prchal@...ignal.cz
Subject: Re: [PATCH] ARM: at91: add usart3 alias to dtsi

Hi Nicolas,

Le 02/12/2013 11:13, Nicolas Ferre a écrit :
> Alias was missing for SoC of the at91sam9x5 familly that embed USART3.
> Preripheral node and pinctrl declarations are already in the
> at91sam9x5_usart3.dtsi file.
>
> Reported-by: Jiri Prchal <jiri.prchal@...ignal.cz>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com>
> ---
>   arch/arm/boot/dts/at91sam9g25.dtsi | 4 ++++
>   arch/arm/boot/dts/at91sam9x25.dtsi | 4 ++++
>   2 files changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/at91sam9g25.dtsi b/arch/arm/boot/dts/at91sam9g25.dtsi
> index 17b879990914..d4650b4e9ebb 100644
> --- a/arch/arm/boot/dts/at91sam9g25.dtsi
> +++ b/arch/arm/boot/dts/at91sam9g25.dtsi
> @@ -14,6 +14,10 @@
>   	model = "Atmel AT91SAM9G25 SoC";
>   	compatible = "atmel,at91sam9g25", "atmel,at91sam9x5";
>   
> +	aliases {
> +		serial4 = &usart3;
> +	};
> +

Shouldn't this go into at91sam9x5_usart3.dtsi ?
This way you would have the same alias for all the SoCs supporting usart3.

Best Regards,

Boris

>   	ahb {
>   		apb {
>   			pinctrl@...ff400 {
> diff --git a/arch/arm/boot/dts/at91sam9x25.dtsi b/arch/arm/boot/dts/at91sam9x25.dtsi
> index c2554219f7a4..aceee86f60eb 100644
> --- a/arch/arm/boot/dts/at91sam9x25.dtsi
> +++ b/arch/arm/boot/dts/at91sam9x25.dtsi
> @@ -15,6 +15,10 @@
>   	model = "Atmel AT91SAM9X25 SoC";
>   	compatible = "atmel,at91sam9x25", "atmel,at91sam9x5";
>   
> +	aliases {
> +		serial4 = &usart3;
> +	};
> +
>   	ahb {
>   		apb {
>   			pinctrl@...ff400 {

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/