linux-kernel - Re: [Patch Part1 V2 07/17] iommu/vt-d, trivial: check suitable flag in function detect_intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <529BE5EF.7040706@huawei.com>
Date:	Mon, 2 Dec 2013 09:44:15 +0800
From:	Yijing Wang <wangyijing@...wei.com>
To:	Jiang Liu <jiang.liu@...ux.intel.com>,
	Yinghai Lu <yinghai@...nel.org>,
	Joerg Roedel <joro@...tes.org>,
	David Woodhouse <dwmw2@...radead.org>,
	"Dan Williams" <dan.j.williams@...el.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Ashok Raj <ashok.raj@...el.com>
CC:	<iommu@...ts.linux-foundation.org>, <linux-pci@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <dmaengine@...r.kernel.org>
Subject: Re: [Patch Part1 V2 07/17] iommu/vt-d, trivial: check suitable flag
 in function detect_intel_iommu()

On 2013/11/29 16:50, Jiang Liu wrote:
> Flag irq_remapping_enabled is only set by intel_enable_irq_remapping(),
> which is called after detect_intel_iommu(). So we should check flag
> disable_irq_remap instead of irq_remapping_enabled in function
> detect_intel_iommu().
> 
> Signed-off-by: Jiang Liu <jiang.liu@...ux.intel.com>
> ---
>  drivers/iommu/dmar.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c
> index f3043a2..77a066b 100644
> --- a/drivers/iommu/dmar.c
> +++ b/drivers/iommu/dmar.c
> @@ -561,7 +561,7 @@ int __init detect_intel_iommu(void)
>  
>  		dmar = (struct acpi_table_dmar *) dmar_tbl;
>  
> -		if (ret && irq_remapping_enabled && cpu_has_x2apic &&
> +		if (ret && !disable_irq_remap && cpu_has_x2apic &&
>  		    dmar->flags & 0x1)
>  			pr_info("Queued invalidation will be enabled to support x2apic and Intr-remapping.\n");
>  
> 

Reviewed-by: Yijing Wang <wangyijing@...wei.com>

-- 
Thanks!
Yijing

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/