linux-kernel - [PATCH 0/2] f2fs: remove debufs dir if debugfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <529C8818.2090002@gmail.com>
Date:	Mon, 02 Dec 2013 21:16:08 +0800
From:	Younger Liu <younger.liucn@...il.com>
To:	Jaegeuk Kim <jaegeuk.kim@...sung.com>
CC:	f2fs <linux-f2fs-devel@...ts.sourceforge.net>,
	kernel <linux-kernel@...r.kernel.org>,
	fs-devel <linux-fsdevel@...r.kernel.org>
Subject: [PATCH 0/2] f2fs: remove debufs dir if debugfs_create_file() failed

From: Younger Liu <liuyiyang@...ense.com>

When debugfs_create_file() failed in f2fs_create_root_stats(),
debugfs_root should be removed.

Signed-off-by: Younger Liu <liuyiyang@...ense.com>
Cc: Younger Liu <younger.liucn@...il.com>
Cc: Jaegeuk Kim <jaegeuk.kim@...sung.com>
---
 fs/f2fs/debug.c |   20 +++++++++++++++++---
 1 file changed, 17 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/debug.c b/fs/f2fs/debug.c
index a84b0a8..d27b689 100644
--- a/fs/f2fs/debug.c
+++ b/fs/f2fs/debug.c
@@ -340,10 +340,24 @@ void f2fs_destroy_stats(struct f2fs_sb_info *sbi)
 
 void __init f2fs_create_root_stats(void)
 {
+    struct dentry *file;
+
     debugfs_root = debugfs_create_dir("f2fs", NULL);
-    if (debugfs_root)
-        debugfs_create_file("status", S_IRUGO, debugfs_root,
-                     NULL, &stat_fops);
+    if (!debugfs_root)
+        goto bail;
+
+    file = debugfs_create_file("status", S_IRUGO,
+            debugfs_root, NULL, &stat_fops);
+    if (!file)
+        goto free_debugfs_dir;
+
+    return;
+
+free_debugfs_dir:
+    debugfs_remove(debugfs_root);
+
+bail:
+    return;
 }
 
 void f2fs_destroy_root_stats(void)
-- 
1.7.9.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/