linux-kernel - Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems on OMAP4 Panda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529C8CBD.4070003@ti.com>
Date:	Mon, 2 Dec 2013 15:35:57 +0200
From:	Roger Quadros <rogerq@...com>
To:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
CC:	Michael Trimarchi <michael@...rulasolutions.com>,
	Felipe Balbi <balbi@...com>, <lee.jones@...aro.org>,
	<sameo@...ux.intel.com>, <tomi.valkeinen@...com>,
	Stefan Roese <sr@...x.de>, <ljkenny.mailinglists@...il.com>,
	Linux OMAP Mailing List <linux-omap@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] mfd: omap-usb-host: Fix USB device detection problems
 on OMAP4 Panda

On 12/02/2013 03:04 PM, Sebastian Andrzej Siewior wrote:
> On 12/02/2013 01:12 PM, Roger Quadros wrote:
>> You are right. The musb hwmod data doesn't have the HWMOD_INIT_NO_RESET
>> flag, so hwmod should reset it during boot.
>>
>> Maybe I too should just remove HWMOD_INIT_NO_RESET flag from the USB Host
>> hwmod data, then we don't need to change this driver at all.
>>
>> Benoit, Tony any comments?
> 
> Almost two years ago in commit de231388 ("ARM: OMAP: USB: EHCI and OHCI
> hwmod structures for OMAP3") the "don't reset flag" has been added by
> Keshava.
> 
> It refers to "Errata Id:i660" why it is required. Once you figured what
> why it has been added you could have an idea if it is okay to remove it
> and if the reset you do here might lead to it (I dunno).
> 

Keshava no longer works @TI. I have no other means to check why it was added
other than doing dome tests and making sure nothing breaks if we remove it.

So far, things are going fine for about 50 or so boots divided between OMAP3 and 4
platforms. If more people can test and give feedback it'd be great.

For the present situation, omap4 panda USB host doesn't work without the reset
with u-boot v2013.10.

cheers,
-roger
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/