[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1312021531340.24931@pobox.suse.cz>
Date: Mon, 2 Dec 2013 15:31:59 +0100 (CET)
From: Jiri Kosina <jkosina@...e.cz>
To: Dave Jones <davej@...hat.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Benjamin Tissoires <benjamin.tissoires@...hat.com>
Subject: Re: HID: kye: Add report fixup for Genius Manticore Keyboard
On Mon, 2 Dec 2013, Dave Jones wrote:
> Commit 4a2c94c9b6 inadvertantly removed a break from the GENIUS_GX_IMPERATOR case.
> Spotted by Coverity.
>
> Signed-off-by: Dave Jones <davej@...oraproject.org>
>
> diff --git a/drivers/hid/hid-kye.c b/drivers/hid/hid-kye.c
> index ecb5ca669e97..e77696367591 100644
> --- a/drivers/hid/hid-kye.c
> +++ b/drivers/hid/hid-kye.c
> @@ -341,6 +341,7 @@ static __u8 *kye_report_fixup(struct hid_device *hdev, __u8 *rdesc,
> case USB_DEVICE_ID_GENIUS_GX_IMPERATOR:
> rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 83,
> "Genius Gx Imperator Keyboard");
> + break;
> case USB_DEVICE_ID_GENIUS_MANTICORE:
> rdesc = kye_consumer_control_fixup(hdev, rdesc, rsize, 104,
I've already taken Ben's original patch:
https://git.kernel.org/cgit/linux/kernel/git/jikos/hid.git/commit/?h=for-3.13/upstream-fixes
--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists