linux-kernel - Re: [PATCH v3 0/4] Add request_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hmwkjcodn.wl%tiwai@suse.de>
Date:	Mon, 02 Dec 2013 15:35:00 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	Prarit Bhargava <prarit@...hat.com>,
	Ming Lei <ming.lei@...onical.com>,
	Borislav Petkov <bp@...e.de>, x86@...nel.org,
	amd64-microcode@...64.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/4] Add request_firmware_direct() for microcode loader

At Mon, 2 Dec 2013 06:32:45 -0800,
Greg Kroah-Hartman wrote:
> 
> On Mon, Dec 02, 2013 at 09:44:13AM +0100, Takashi Iwai wrote:
> > At Sat, 16 Nov 2013 06:24:55 +0900,
> > Greg Kroah-Hartman wrote:
> > > 
> > > On Fri, Nov 15, 2013 at 04:34:09PM +0100, Takashi Iwai wrote:
> > > > At Tue, 12 Nov 2013 13:02:12 +0100,
> > > > Takashi Iwai wrote:
> > > > > 
> > > > > Hi,
> > > > > 
> > > > > this is a revised patch series to introduce request_firmware_direct()
> > > > > helper for avoiding the lengthy udev issue on microcode loader.
> > > > > The original problem was stated in Prarit's post:
> > > > >    https://lkml.org/lkml/2013/10/28/221
> > > > > 
> > > > > In short, microcode loader probes non-existing firmware files (which
> > > > > are cases with every new chip), and each probe takes 60 seconds,
> > > > > resulting in too long time until completed.
> > > > > 
> > > > > This solution is simply avoiding the udev fallback in
> > > > > request_firmware() explicitly for drivers like microcode.
> > > > > 
> > > > > Of course, this doesn't mean to throw away further optimizations like
> > > > > Prarit's patch.  It can be implemented in parallel with this.
> > > > > 
> > > > > 
> > > > >  [PATCH v3 1/4] firmware: Introduce request_firmware_direct()
> > > > >  [PATCH v3 2/4] microcode: Use request_firmware_direct()
> > > > >  [PATCH v3 3/4] firmware: Use bit flags instead of boolean combos
> > > > >  [PATCH v3 4/4] firmware: Suppress fallback warnings when CONFIG_FW_LOADER_USER_HELPER=n
> > > > > 
> > > > > v1->v2: Rebased on linux-next, add a fix for a bogus warning message
> > > > > v2->v3: Convert to bit flags, fix warning message differently
> > > > > 
> > > > > 
> > > > > Greg, could you take these patches through your driver tree, as
> > > > > most of fixes are about the firmware loader itself.
> > > > 
> > > > Greg, any chance to take a look at these patches?
> > > 
> > > I'm traveling at the moment, in Korea this week.  I'll take a look at
> > > them after 3.13-rc1 is out, as I can't do anything with patches until
> > > then.  Don't worry, they aren't lost.
> > 
> > They seem lost in Korea in the end :)
> 
> No, not lost:
> 	$ mdfrm -c ~/mail/todo/
> 	2485 messages in /home/gregkh/mail/todo/
> 
> Just burried :(

Wow, impressive numbers...

> > Could you catch up if still OK?
> 
> I'll get to them soon...
> 
> > One of the patches seems slightly conflicting with the latest Linus
> > tree.  I can send a rebased one if needed, or you can take it from
> >   git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-unstable.git test/fw-direct
> 
> Yes please, an update would be good to have, can you just send this in
> email form?

Alright, will do soon.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/