linux-kernel - Re: [GIT PULL 0/5] perf/urgent fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 2 Dec 2013 09:58:42 +0300
From:	Brian Gitonga Marete <marete@...hnix.com>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	LKML <linux-kernel@...r.kernel.org>,
	Adrian Hunter <adrian.hunter@...el.com>,
	Andi Kleen <ak@...ux.intel.com>,
	David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>, Jiri Olsa <jolsa@...hat.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [GIT PULL 0/5] perf/urgent fixes

On Thu, Sep 12, 2013 at 8:45 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:
>
>> Em Wed, Sep 11, 2013 at 07:55:03AM +0200, Ingo Molnar escreveu:
>> >  16645 perf_event_open(0x1eb7f00, 0xffffffff, 0, 0xffffffff, 0) = -1 EINVAL (Invalid argument)
>> >
>> > Caused by:
>> >
>> >  575a9aab0f85 perf tools: Add attr->mmap2 support
>> >
>> > We must not force mmap2 support to be present on the kernel side - new
>> > perf top should work on older kernels just as well.
>> >
>> > So I've unpulled the tree for now.
>>
>> yeah, I noticed this late yesterday, made it to work like the fallback
>> for perf_event_attr.{sample_id_all,exclude_{guest,host}} and folded that
>> into Stephane's patch, with a committer note, to keep things bisectable.
>>
>> Can you please do a test pull with the updated branch + tag below? If
>> you prefer me to do the whole dance and send a regular pull request,
>> please let me now.
>
> Pulled, thanks a lot Arnaldo! 'perf top' works fine here now on older
> kernels as well.

Hello all. So, I am seeing this with kernel 3.12.2 with the perf
binary bundled with that  kernel:

13372 perf_event_open(0x1713cd0, 0xffffffff, 0, 0xffffffff, 0) = -1
EINVAL (Invalid argument)
13372 perf_event_open(0x1713cd0, 0xffffffff, 0, 0xffffffff, 0) = -1
EINVAL (Invalid argument)
13372 perf_event_open(0x1713cd0, 0xffffffff, 0, 0xffffffff, 0) = -1
EINVAL (Invalid argument)


For perf_event_paranoid, I have

$cat /proc/sys/kernel/perf_event_paranoid
-1

And the error still manifests with perf_event_paranoid set to 0.

My kernel config is attached as config-3.12.2.txt

-- 
Brian Gitonga Marete
CEO/CTO Toshnix Systems
http://toshnix.com

View attachment "config-3.12.2.txt" of type "text/plain" (153765 bytes)