linux-kernel - Re: [PATCH] HID: logitech-dj: add HIDRAW dependency in Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1312030852410.24931@pobox.suse.cz>
Date:	Tue, 3 Dec 2013 08:53:46 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Olivier Gay <ogay@...itech.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nestor Lopez Casado <nlopezcasad@...itech.com>,
	Mathieu Meisser <mmeisser@...itech.com>
Subject: Re: [PATCH] HID: logitech-dj: add HIDRAW dependency in Kconfig

On Tue, 3 Dec 2013, Olivier Gay wrote:

> hid-logitech-dj.c driver needs hidraw to work correctly. Without
> hidraw, hid-logitech-dj.c fails during probe() and Logitech
> Unifying devices HID reports aren't recognized.
> 
> Signed-off-by: Olivier Gay <ogay@...itech.com>
> Signed-off-by: Nestor Lopez Casado <nlopezcasad@...itech.com>
> Signed-off-by: Mathieu Meisser <mmeisser@...itech.com>
> ---
> 
> Hi everyone,
> 
> this adds a HIDRAW dependency in Kconfig for hid-logitech-dj.c
> driver. The driver uses hidraw and needs it to work correctly.
> 
> Without hidraw if a Logitech Unifying device is plugged, the driver
> fails during probe() and Logitech Unifying devices HID reports aren't
> recognized. This has been the cause of some confusion. Some Linux and
> Android distributions had HID_LOGITECH_DJ enabled without HIDRAW and
> the Unifying mice and keyboards would simply not work (no cursor

Hi Oliver,

I don't have my receiver with me at the moment, so can't really verify -- 
how exactly does it fail during probe()?

It's clear that without hidraw it's not possible to change the pairing 
from userspace, but I fail to see why probing the receiver should be 
affected?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/