linux-kernel - Re: [PATCH v12 06/18] vmscan: rename shrink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Dec 2013 21:04:21 +1100
From:	Dave Chinner <david@...morbit.com>
To:	Vladimir Davydov <vdavydov@...allels.com>
Cc:	hannes@...xchg.org, mhocko@...e.cz, dchinner@...hat.com,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, cgroups@...r.kernel.org, devel@...nvz.org,
	glommer@...nvz.org, Mel Gorman <mgorman@...e.de>,
	Rik van Riel <riel@...hat.com>
Subject: Re: [PATCH v12 06/18] vmscan: rename shrink_slab() args to make it
 more generic

On Tue, Dec 03, 2013 at 01:44:38PM +0400, Vladimir Davydov wrote:
> On 12/03/2013 01:33 PM, Dave Chinner wrote:
> >> kmemcg reclaim is introduced, we will have to make up phony values for
> >> nr_pages_scanned and lru_pages again when doing kmem-only reclaim for a
> >> memory cgroup, which is possible if the cgroup has its kmem limit less
> >> than the total memory limit.
> > I'm missing something here - why would memcg reclaim require
> > passing phony values? How are you going to keep slab caches in
> > balance with memory pressure generated by the page cache?
> 
> To perform kmem-only reclaim - please see patch 13. When the kmem limit
> is less than the user limit, we can reach only the kmem limit. It is no
> use trying to reclaim page cache then.

Oh dear. What a nasty hack.

Dave.
-- 
Dave Chinner
david@...morbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/