linux-kernel - Re: [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 Dec 2013 11:01:38 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	micky <micky_ching@...lsil.com.cn>
Cc:	sameo@...ux.intel.com, devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	wei_wang@...lsil.com.cn, rogerable@...ltek.com
Subject: Re: [PATCH v2 3/3] mfd: rtsx: prevent 'used uninitialised' warnings

> >This should contain the author's name.
> >
> >You should use:
> >    `git rebase -i` /* Use edit option */
> >then
> >   `git commit --amend --author="First Last <first.last@...il.com>"
> >
> >To apply it.
> >
> Sorry Lee, I will modify it. Is the order important? or only your
> name is need here?
> >>drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
> >>drivers/mfd/rtl8411.c:58:7: warning: 'reg1' is used uninitialized in this function [-Wuninitialized]
> >>drivers/mfd/rtl8411.c: In function 'rtl8411b_fetch_vendor_settings':
> >>drivers/mfd/rtl8411.c:79:7: warning: 'reg' is used uninitialized in this function [-Wuninitialized]
> >>drivers/mfd/rtl8411.c: In function 'rtl8411_fetch_vendor_settings':
> >>drivers/mfd/rtl8411.c:69:26: warning: 'reg3' may be used uninitialized in this function [-Wuninitialized]
> >>
> >>Signed-off-by: Lee Jones <lee.jones@...aro.org>
> >>Tested-by: Micky Ching <micky_ching@...lsil.com.cn>
> >I know this is a bit of a strange situation, but whenever you sent
> >patches to the MLs,  you need to sign it off yourself too.

Actually, you don't need to worry now. I already applied the patch
with the correct author applied with your Ack.

> Did you mean I need write like this ?
> 
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> Tested-by: Micky Ching <micky_ching@...lsil.com.cn>
> Signed-off-by: Micky Ching <micky_ching@...lsil.com.cn>

As I say, this situation is a bit different, but in the normal case,
yes. Then the Maintainer will probably remove some and chop them
around a little to his/her liking.

FYI: The top SoB is usually the author, the subsequent ones are
usually gatekeepers of upstream repos. Anyone can take a patch and
submit it though, so in the case where the submitter isn't the author,
the second SoB is usually the patch submitter.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/