linux-kernel - Re: [PATCH v3] gpio: better lookup method for platform GPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131203110412.GC26423@xps8300>
Date:	Tue, 3 Dec 2013 13:04:12 +0200
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Alexandre Courbot <acourbot@...dia.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Rhyland Klein <rklein@...dia.com>, linux-gpio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] gpio: better lookup method for platform GPIOs

Hi,

On Tue, Dec 03, 2013 at 12:20:11PM +0900, Alexandre Courbot wrote:
> Change the format of the platform GPIO lookup tables to make them less
> confusing and improve lookup efficiency.
> 
> The previous format was a single linked-list that required to compare
> the device name and function ID of every single GPIO defined for each
> lookup. Switch that to a list of per-device tables, so that the lookup
> can be done in two steps, omitting the GPIOs that are not relevant for a
> particular device.
> 
> The matching rules are now defined as follows:
> - The device name must match *exactly*, and can be NULL for GPIOs not
>   assigned to a particular device,
> - If the function ID in the lookup table is NULL, the con_id argument of
>   gpiod_get() will not be used for lookup. However, if it is defined, it
>   must match exactly.
> - The index must always match.
> 
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> Acked-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
> Changes since v2:
> - Removed size member of the gpiod_lookup_table struct (thanks Heikki!)
> - Added Andy's reviewed-by
> 
>  Documentation/gpio/board.txt |  28 ++++++-----
>  drivers/gpio/gpiolib.c       | 108 +++++++++++++++++++++++--------------------
>  include/linux/gpio/driver.h  |  21 ++++-----
>  3 files changed, 85 insertions(+), 72 deletions(-)

Looks good. Thanks Alexandre!


-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/