[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20131203143010.GB3521@kroah.com>
Date: Tue, 3 Dec 2013 06:30:10 -0800
From: Greg KH <gregkh@...uxfoundation.org>
To: Frank Haverkamp <haver@...ux.vnet.ibm.com>
Cc: linux-kernel@...r.kernel.org, arnd@...db.de,
cody@...ux.vnet.ibm.com, schwidefsky@...ibm.com,
utz.bacher@...ibm.com, mmarek@...e.cz, rmallon@...il.com,
jsvogt@...ibm.com, MIJUNG@...ibm.com, cascardo@...ux.vnet.ibm.com,
michael@...ra.de
Subject: Re: [PATCH 1/6] GenWQE PCI support, health monitoring and recovery
On Tue, Dec 03, 2013 at 02:35:17PM +0100, Frank Haverkamp wrote:
> > > +/* common struct for chip image exchange */
> > > +struct chip_bitstream {
> > > + uint8_t __user *pdata; /* pointer to image data */
> > > + int size; /* size of image file */
> >
> > I think this fails the 32/64bit issue, right?
>
> Yes. I replaced those by something like
> __u32 data_addr;
> I hope that is fixing the 32/64bit issue.
No, not at all, how are you going to put a 64bit userspace pointer in
there?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists