linux-kernel - Re: [PATCH 7/9] staging/lustre/llite: remove ll_file_get_iov

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 04 Dec 2013 01:26:31 +0800
From:	Peng Tao <bergwolf@...il.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:	linux-kernel@...r.kernel.org,
	Andreas Dilger <andreas.dilger@...el.com>
Subject: Re: [PATCH 7/9] staging/lustre/llite: remove ll_file_get_iov_count

On 12/04/2013 01:00 AM, Greg Kroah-Hartman wrote:
> On Tue, Dec 03, 2013 at 10:42:06PM +0800, Peng Tao wrote:
>> It exactly copies generic_segment_checks() except wrongly calling
>> access_ok(VERIFY_READ) for aio read range. Drop it and just call
>> generic_segment_checks() instead.
>>
>> Signed-off-by: Peng Tao <bergwolf@...il.com>
>> Signed-off-by: Andreas Dilger <andreas.dilger@...el.com>
>> ---
>>   drivers/staging/lustre/lustre/llite/file.c |   36 ++--------------------------
>>   1 file changed, 2 insertions(+), 34 deletions(-)
>
> This patch breaks the build, in numerous ways, which means you didn't
> even build test this patch.
>
> PLEASE be more careful, it's getting such that I really dread seeing
> these patches show up in my inbox...
I am truly sorry. This one was added in the last and got in the middle 
after I reordered the series. Then I was under the impression that it 
was included when I tested the code. Really sorry for causing the 
trouble. I will be more careful.

I'll fix up and resend the rest of the series. Sorry for the noise.

Thanks,
Tao



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/