linux-kernel - Re: [PATCH] watchdog: Add a sysctl to disable soft lockup detector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131203142751.34475fce138ce996d22db784@linux-foundation.org>
Date:	Tue, 3 Dec 2013 14:27:51 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Ben Zhang <benzh@...omium.org>
Cc:	linux-kernel@...r.kernel.org, Don Zickus <dzickus@...hat.com>,
	Ingo Molnar <mingo@...hat.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] watchdog: Add a sysctl to disable soft lockup detector

On Tue,  3 Dec 2013 13:54:34 -0800 Ben Zhang <benzh@...omium.org> wrote:

> This provides usermode a way to disable only the soft
> lockup detector while keeping the hard lockup detector
> running.

Please update the changelog to describe the current behavior.

Please also describe why you think that behavior should be changed. 
ie: what's the reason for this patch.

Please update Documentation/ for this feature.  Probably that's
kernel-parameters.txt for the boot option and sysctl/kernel.txt for the
procfs addition.

> --- a/include/linux/sched.h
> +++ b/include/linux/sched.h
> @@ -270,6 +270,7 @@ extern int proc_dowatchdog_thresh(struct ctl_table *table, int write,
>  				  void __user *buffer,
>  				  size_t *lenp, loff_t *ppos);
>  extern unsigned int  softlockup_panic;
> +extern unsigned int  softlockup_detector_enable;

Remove unneeded space while we're in there.

> --- a/kernel/sysctl.c
> +++ b/kernel/sysctl.c
> @@ -840,6 +840,15 @@ static struct ctl_table kern_table[] = {
>  		.extra2		= &one,
>  	},
>  	{
> +		.procname	= "softlockup_detector_enable",
> +		.data		= &softlockup_detector_enable,
> +		.maxlen		= sizeof(int),
> +		.mode		= 0644,
> +		.proc_handler	= proc_dointvec_minmax,
> +		.extra1		= &zero,
> +		.extra2		= &one,
> +	},

And let's describe the full procfs path to this pseudo-file within the
changelog.

>  		.procname       = "nmi_watchdog",
>  		.data           = &watchdog_user_enabled,
>  		.maxlen         = sizeof (int),

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/