lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 03 Dec 2013 23:45:15 -0800 From: Joe Perches <joe@...ches.com> To: Dan Carpenter <dan.carpenter@...cle.com> Cc: Aldo Iljazi <mail@...o.io>, Samuel Thibault <samuel.thibault@...-lyon.org>, w.d.hubbs@...il.com, chris@...-brannons.com, kirk@...sers.ca, gregkh@...uxfoundation.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Andy Whitcroft <apw@...onical.com> Subject: Re: [PATCH] Staging: speakup: synth.c: removed a space On Wed, 2013-12-04 at 10:38 +0300, Dan Carpenter wrote: > On Wed, Dec 04, 2013 at 06:35:15AM +0200, Aldo Iljazi wrote: > > Samuel Thibault wrote: > > > > > Err, I'd rather make it really visible that the for loop doesn't have > > > its first statement? > > > > Wouldn't it be better if you add a comment there? So it would follow the > > coding style? > > No. Adding obvious comments is more annoying than the space. > > This seems like a small bug in checkpatch.pl. Joe, the problem is this > code: > > for ( ; x; x++) { > > It's complaining about the space character before the semicolon. Shrug. checkpatch isn't and can't be perfect. I think it's for things like for (;;) and that's better than for ( ; ; ) or for ( ;; ) or for ( ;;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists