| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1386146344-17185-1-git-send-email-vdavydov@parallels.com> Date: Wed, 4 Dec 2013 12:39:04 +0400 From: Vladimir Davydov <vdavydov@...allels.com> To: <linux-kernel@...r.kernel.org> CC: <devel@...nvz.org>, Al Viro <viro@...iv.linux.org.uk> Subject: [PATCH] fs: fix WARN on alloc_super() fail path On fail path alloc_super() calls destroy_super(), which issues a warning if list_empty() returns false on the s_mounts field. That said s_mounts should be initialized in alloc_super() before any possible failure. Signed-off-by: Vladimir Davydov <vdavydov@...allels.com> Cc: Al Viro <viro@...iv.linux.org.uk> --- fs/super.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/super.c b/fs/super.c index e5f6c2c..cecd780 100644 --- a/fs/super.c +++ b/fs/super.c @@ -166,6 +166,8 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags) if (!s) return NULL; + INIT_LIST_HEAD(&s->s_mounts); + if (security_sb_alloc(s)) goto fail; @@ -188,7 +190,6 @@ static struct super_block *alloc_super(struct file_system_type *type, int flags) if (list_lru_init(&s->s_inode_lru)) goto fail; - INIT_LIST_HEAD(&s->s_mounts); init_rwsem(&s->s_umount); lockdep_set_class(&s->s_umount, &type->s_umount_key); /* -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists