linux-kernel - Re: [PATCH 3/3] perf report: Add --show-time-info option

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131204101117.GC2363@gmail.com>
Date:	Wed, 4 Dec 2013 11:11:17 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>
Cc:	David Ahern <dsahern@...il.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Stephane Eranian <eranian@...gle.com>,
	Andi Kleen <andi@...stfloor.org>,
	Pekka Enberg <penberg@...nel.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 3/3] perf report: Add --show-time-info option


* Arnaldo Carvalho de Melo <acme@...stprotocols.net> wrote:

> Em Mon, Dec 02, 2013 at 12:58:35PM -0700, David Ahern escreveu:
> > On 12/2/13, 12:38 PM, Arnaldo Carvalho de Melo wrote:
> > >Can you suggest a better name for the option being discussed?
> 
> > >Perhaps one of:
> 
> > >--show-event-time
> > >--event-time
> 
> > >?
> > 
> > Why not just --event-time?
> 
>  
> > Really should have dropped the 'show' from the recent perf-script
> > change (just --task-events and --mmap-events).
> 
> Probably, yeah, Ingo made some point about using --show- for some reason,
> Ingo?

So the reason for my suggestion was that I've noticed a proliferation 
of such flags in perf report. To reduce namespace pollution it's 
always good to bring a certain kind of hierarchy into command line 
options.

Options that work alike should spell alike. Users shouldn't be 
required to memorize every naming quirk of the various disjunct 
'display this extra data' options.

So if we expect more --show options in the future (and in particular 
if there are existing oddball options that could be changed to the 
--show-xyz pattern) then I'd suggest to do it unified. For example 
there's --show-nr-samples and --show-info already which follows this 
pattern.

This pattern would distinguish this option from the other perf report 
options, such as --vmlinux, --force, --sort, etc.

It might even make sense to unify it all into a single --show option. 
That would allow the following current mismash of options:

       --task-events --mmap-events --show-nr-samples --show-info

to be replaced by a much more obvious, much more coherent looking 
option sequence:

	--show task-events,mmap-events,nr-samples,info

an added bonus would be that '--show help' could be implemented as 
well, to list all displayable extra data.

(I'm not married to the specific naming, it could be something else as 
well, like --display or --report.)

Or something like that.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/