linux-kernel - Re: [PATCH] ARM: pxa: Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <529F033E.9020608@gmail.com>
Date:	Wed, 04 Dec 2013 11:26:06 +0100
From:	Daniel Mack <zonque@...il.com>
To:	Thierry Reding <thierry.reding@...il.com>,
	Eric Miao <eric.y.miao@...il.com>,
	Russell King <linux@....linux.org.uk>,
	Haojian Zhuang <haojian.zhuang@...il.com>
CC:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: pxa: Remove unused variables

On 12/04/2013 11:22 AM, Thierry Reding wrote:
> The conf and of_id variables are assigned but never used, so they may as
> well just be removed.
> 
> Signed-off-by: Thierry Reding <thierry.reding@...il.com>

Acked-by: Daniel Mack <zonque@...il.com>

> ---
>  arch/arm/mach-pxa/irq.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/irq.c b/arch/arm/mach-pxa/irq.c
> index b6cc1816463e..0eecd83c624e 100644
> --- a/arch/arm/mach-pxa/irq.c
> +++ b/arch/arm/mach-pxa/irq.c
> @@ -235,8 +235,6 @@ static const struct of_device_id intc_ids[] __initconst = {
>  void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
>  {
>  	struct device_node *node;
> -	const struct of_device_id *of_id;
> -	struct pxa_intc_conf *conf;
>  	struct resource res;
>  	int n, ret;
>  
> @@ -245,8 +243,6 @@ void __init pxa_dt_irq_init(int (*fn)(struct irq_data *, unsigned int))
>  		pr_err("Failed to find interrupt controller in arch-pxa\n");
>  		return;
>  	}
> -	of_id = of_match_node(intc_ids, node);
> -	conf = of_id->data;
>  
>  	ret = of_property_read_u32(node, "marvell,intc-nr-irqs",
>  				   &pxa_internal_irq_nr);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/