linux-kernel - Re: [PATCH 22/41] rcu: Replace __this_cpu_ptr uses with raw_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131204011255.GB15492@linux.vnet.ibm.com>
Date:	Tue, 3 Dec 2013 17:12:55 -0800
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Christoph Lameter <cl@...ux.com>
Cc:	Tejun Heo <tj@...nel.org>, akpm@...uxfoundation.org,
	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Dipankar Sarma <dipankar@...ibm.com>
Subject: Re: [PATCH 22/41] rcu: Replace __this_cpu_ptr uses with raw_cpu_ptr

On Tue, Dec 03, 2013 at 05:32:54PM -0600, Christoph Lameter wrote:
> __this_cpu_ptr is being phased out.
> 
> One special case is increment_cpu_stall_ticks().
> A per cpu variable is incremented so use raw_cpu_inc().
> 
> Cc: Dipankar Sarma <dipankar@...ibm.com>
> Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> Signed-off-by: Christoph Lameter <cl@...ux.com>

This does not build on 3.13-rc2.  Ah, need a couple of patches earlier
in the series.

But...  But...  Didn't we recently change -to- __this_cpu_ptr() from
the older __get_cpu_var()?

							Thanx, Paul

------------------------------------------------------------------------
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c: In function ‘rcu_adopt_orphan_cbs’:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:1943:9: error: implicit declaration of function ‘raw_cpu_ptr’ [-Werror=implicit-function-declaration]
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:1943:25: warning: initialization makes pointer from integer without a cast [enabled by default]
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c: In function ‘__rcu_process_callbacks’:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:2322:25: warning: initialization makes pointer from integer without a cast [enabled by default]
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c: In function ‘rcu_barrier_func’:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:2923:25: warning: initialization makes pointer from integer without a cast [enabled by default]
In file included from /media/homes/git/linux-2.6-tip/kernel/rcu/tree.c:3467:0:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree_plugin.h: In function ‘rcu_oom_notify_cpu’:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree_plugin.h:1846:7: warning: assignment makes pointer from integer without a cast [enabled by default]
/media/homes/git/linux-2.6-tip/kernel/rcu/tree_plugin.h: In function ‘increment_cpu_stall_ticks’:
/media/homes/git/linux-2.6-tip/kernel/rcu/tree_plugin.h:1988:3: error: implicit declaration of function ‘raw_cpu_inc’ [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
make[2]: *** [kernel/rcu/tree.o] Error 1
make[1]: *** [kernel/rcu/tree.o] Error 2
make: *** [sub-make] Error 2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/