linux-kernel - Re: [PATCH 06/39] dma: remove DEFINE_PCI_DEVICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1386161310.1871.62.camel@smile>
Date:	Wed, 04 Dec 2013 14:48:30 +0200
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Greg Kroah-Hartman' <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org,
	"'Koul, Vinod'" <vinod.koul@...el.com>,
	"'Williams, Dan J'" <dan.j.williams@...el.com>,
	dmaengine@...r.kernel.org, 'Joe Perches' <joe@...ches.com>,
	'Jonas Bonn' <jonas@...thpole.se>
Subject: Re: [PATCH 06/39] dma: remove DEFINE_PCI_DEVICE_TABLE macro

On Wed, 2013-12-04 at 09:19 +0900, Jingoo Han wrote:
> On Tuesday, December 03, 2013 9:11 PM, Shevchenko, Andriy wrote:
> > On Tue, 2013-12-03 at 08:05 +0900, Jingoo Han wrote:
> > > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> > > is not preferred.
> > 
> > I'm sorry, but Documentation/PCI/pci.txt still says "is the preferred
> > method".
> > 
> > Is there any link to patch for Documentation and discussion why change
> > is established?
> 
> (+cc Joe Perches, Jonas Bonn)
> 
> Since last week, there has been discussion about this.
> There is no special reason to use DEFINE_PCI_DEVICE_TABLE macro.
> 
> According to the Greg Kroah-Hartman,
> "Yeah, and it's a horrid macro that deserves to be removed,
> please don't use it in more places."
> 
> Currently, there is no other bus that has something like this
> macro for their device ids. Thus, DEFINE_PCI_DEVICE_TABLE macro
> should be removed.
> 
> Jonas Bonn (author of DEFINE_PCI_DEVICE_TABLE macro) also agreed
> to remove this macro. According to Jonas Bonn,
> "Actually, I think I submitted an even uglier macro called 
> DECLARE_PCI_DEVICE_TABLE... might have been the first kernel
> Patch I  ever sent?  In any case, it should certainly have been
> kindly rejected."
> 
> After Joe Perches's patch[1] is merged, I will send these patches
> to each subsystem maintainer.
> 
> [1][PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE
>     (http://lkml.org/lkml/2013/12/2/400)
> 
> In this patch, Joe Perches fixed 'Documentation/PCI/pci.txt', and
> 'scripts/checkpatch.pl', in order to guide to use 'struct pci_device_id'
> instead of 'DEFINE_PCI_DEVICE_TABLE' macro.

Thanks for the detailed explanation!

Thus, give you my 

Acked-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

for drivers/dma/dw/ part.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/