linux-kernel - Re: [PATCH] Staging: bcm: DDRInit: Fixed non

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131204125646.GQ28413@mwanda>
Date:	Wed, 4 Dec 2013 15:56:47 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Gary Rookard <garyrookard@...il.com>
Cc:	gregkh@...uxfoundatio.org, devel@...verdev.osuosl.org,
	lisa@...apiadmin.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: bcm: DDRInit: Fixed non_standard kernel style.

On Wed, Dec 04, 2013 at 04:53:09AM -0500, Gary Rookard wrote:
> Fixed non_standard kernel style.
> 

You're doing too many things at once, it needs to be broken into
a patch series which do one type of change at a time.

The changelog is useless.

> Signed off by: Gary Alan Rookard <garyrookard@...il.com>
> ---
>  drivers/staging/bcm/DDRInit.c | 2081 +++++++++++++++++++----------------------
>  1 file changed, 977 insertions(+), 1104 deletions(-)
> 
> diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
> index 9f7e30f..2fc3ba9 100644
> --- a/drivers/staging/bcm/DDRInit.c
> +++ b/drivers/staging/bcm/DDRInit.c
> @@ -1,977 +1,876 @@
> -#include "headers.h"
> -
> +/* File: DDRInit.c */

This isn't useful.

> +	{0x0F000840, 0x0FFF1B00},  /* Changed Source for X-bar and MIPS Clock to APLL */
> +	{0xF0000870, 0x00000002},
> +	{0x0F00A044, 0x1FFFFFFF},
> +	{0x0F00A040, 0x1F000000},

One of these is not like the others.  You have introduced a bug with
0xF0000870 vs 0x0F000870.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/