linux-kernel - Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131204134156.GA25422@lee--X1>
Date:	Wed, 4 Dec 2013 13:41:56 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Krzysztof Kozlowski <k.kozlowski@...sung.com>
Cc:	Rob Herring <rob.herring@...xeda.com>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Stephen Warren <swarren@...dotorg.org>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Rob Landley <rob@...dley.net>,
	Anton Vorontsov <anton@...msg.org>,
	David Woodhouse <dwmw2@...radead.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Chanwoo Choi <cw00.choi@...sung.com>
Subject: Re: [PATCH v6 3/3] mfd: max14577: Add device tree bindings document

> > > +MAXIM MAX14577 multi-function device
> > 
> > Why is Maxim capitalised in such a way?
> > 
> > If you're going to use the term Multi-Function Device, please
> > capitalise it.
> > 
> > > +MAX14577 is a Multi-function device with Micro-USB Interface Circuit, Li+
> > 
> > Same here.
> 
> I'll fix this. The MAXIM capitalization came from other drivers.

No need to repeat mistakes. I believe it should be Maxim.

> > > +Example:
> > > +	max14577@25 {
> > > +		compatible = "maxim,max14577";
> > > +		reg = <0x25>;
> > > +		interrupt-parent = <&gpx1>;
> > > +		interrupts = <5 0>;
> > 
> > I'm gussing this is IRQ5 and the 0 is flags? If so, please use
> > #defines for the flags.
> 
> This is a standard interrupt binding. The max14577 MFD core driver
> ignores the interrupt flags and always uses IRQF_TRIGGER_FALLING. I can
> fix this with new patch for drivers/mfd/max14577.c but still I don't see
> what should be added in documentation.

s/0/IRQ_TYPE_NONE

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/