linux-kernel - Re: [PATCH v2] OF: base: match each node compatible against all given matches first

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131204140457.GA2272@ulmo.nvidia.com>
Date:	Wed, 4 Dec 2013 15:04:59 +0100
From:	Thierry Reding <thierry.reding@...il.com>
To:	Meelis Roos <mroos@...ux.ee>
Cc:	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Russell King <linux@....linux.org.uk>,
	Marc Kleine-Budde <mkl@...gutronix.de>,
	Scott Wood <scottwood@...escale.com>,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH v2] OF: base: match each node compatible against all
 given matches first

On Wed, Dec 04, 2013 at 03:08:39PM +0200, Meelis Roos wrote:
> > I added Meelis on Cc because he found a regression with my original
> > proposal (107a84e61cdd "of: match by compatible property first"). That
> > got later reverted in commit bc51b0c22ceb (Revert "of: match by
> > compatible property first"). Here's the commit message for reference:
> > 
> > commit bc51b0c22ceb
> > Author: Linus Torvalds <torvalds@...ux-foundation.org>
> > Date:   Tue Jul 10 12:49:32 2012 -0700
> > 
> >     Revert "of: match by compatible property first"
> > 
> >     This reverts commit 107a84e61cdd3406c842a0e4be7efffd3a05dba6.
> > 
> >     Meelis Roos reports a regression since 3.5-rc5 that stops Sun Fire V100
> >     and Sun Netra X1 sparc64 machines from booting, hanging after enabling
> >     serial console.  He bisected it to commit 107a84e61cdd.
> > 
> >     Rob Herring explains:
> >      "The problem is match combinations of compatible plus name and/or type
> >       fail to match correctly.  I have a fix for this, but given how late it
> >       is for 3.5 I think it is best to revert this for now.  There could be
> >       other cases that rely on the current although wrong behavior.  I will
> >       post an updated version for 3.6."
> > 
> >     Bisected-and-reported-by: Meelis Roos <mroos@...ux.ee>
> >     Requested-by: Rob Herring <rob.herring@...xeda.com>
> >     Cc: Thierry Reding <thierry.reding@...onic-design.de>
> >     Cc: Grant Likely <grant.likely@...retlab.ca>
> >     Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
> > 
> > So if Meelis still has access to the Sun Fire V100 and Sun Netra X1
> > machines that regressed last time around, it'd be great to get this
> > patch tested on them to verify that it indeed fixes the problem and
> > doesn't regress.
> 
> OK, I had forgotten about that.

Yeah, I had always meant to come back to it, but that never quite
happened, so I'm all the more glad that Sebastian took over.

> Tested successfully on the same Sun Fire V100 and Sun Netra X1, on top 
> of 3.13-rc2. The sunsu console is detected fine and I see no problem for 
> now.

Excellent. Thanks for testing!

Rob, I guess this should be reasonable safe then to take for a spin in
linux-next?

Thierry

Content of type "application/pgp-signature" skipped