linux-kernel - Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131204134433.GD1573@shlinux1.ap.freescale.net>
Date:	Wed, 4 Dec 2013 21:44:34 +0800
From:	Peter Chen <peter.chen@...escale.com>
To:	<dt.tangr@...il.com>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding
 of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'

On Wed, Dec 04, 2013 at 08:20:07PM +1100, dt.tangr@...il.com wrote:
> From: Daniel Tang <dt.tangr@...il.com>
> 
> The SoC name was mistakenly used instead of the vendor name in the
> device tree binding for nspire-usb.
> 
> This patch fixes this before the driver becomes widely adopted.
> 
> Signed-off-by: Daniel Tang <dt.tangr@...il.com>
> ---
>  Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt |    4 ++--
>  drivers/usb/chipidea/ci_hdrc_nspire.c                    |    2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> index 5ba8e90..ef1fcbf 100644
> --- a/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> +++ b/Documentation/devicetree/bindings/usb/ci-hdrc-nspire.txt
> @@ -1,7 +1,7 @@
>  * TI-Nspire USB OTG Controller
>  
>  Required properties:
> -- compatible: Should be "zevio,nspire-usb"
> +- compatible: Should be "lsi,nspire-usb"

lsi is vendor name, what are zevio and nspire?
Usually, the compatible string should be "vendor_name,soc_name-module_name"

>  - reg: Should contain registers location and length
>  - interrupts: Should contain controller interrupt
>  
> @@ -11,7 +11,7 @@ Recommended properies:
>  Examples:
>  		usb0: usb@...00000 {
>  			reg = <0xB0000000 0x1000>;
> -			compatible = "zevio,nspire-usb";
> +			compatible = "lsi,nspire-usb";
>  			interrupts = <8>;
>  			vbus-supply = <&vbus_reg>;
>  		};
> diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c
> index 517ce41..c5c2dde 100644
> --- a/drivers/usb/chipidea/ci_hdrc_nspire.c
> +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c
> @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id ci_hdrc_nspire_dt_ids[] = {
> -	{ .compatible = "zevio,nspire-usb", },
> +	{ .compatible = "lsi,nspire-usb", },
>  	{ /* sentinel */ }
>  };
>  
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/