linux-kernel - Re: [PATCH v2 2/6] x86: Add Intel graphics stolen memory quirk for gen2 platforms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131204151550.GA5502@gmail.com>
Date:	Wed, 4 Dec 2013 16:15:50 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Ville Syrjälä <ville.syrjala@...ux.intel.com>
Cc:	intel-gfx@...ts.freedesktop.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/6] x86: Add Intel graphics stolen memory quirk for
 gen2 platforms


* Ville Syrjälä <ville.syrjala@...ux.intel.com> wrote:

> On Wed, Dec 04, 2013 at 10:08:14AM +0100, Ingo Molnar wrote:
> > 
> > * ville.syrjala@...ux.intel.com <ville.syrjala@...ux.intel.com> wrote:
> > 
> > > v2: Rewrite to use the TOM-TSEG_SIZE-stolen_size and TOUD methods
> > 
> > I guess v2 is a reaction to my review feedback? I got no reply to my 
> > mail from you so I'm not sure and I'd like to know whether all 
> > feedback was addressed.
> 
> Actually this was mostly insipired by a private mail from hpa. I forgot
> to reply to your mail, sorry about that.
> 
> But anyways, I think apart from your comment about the KB/MB macros,
> the rest of the comments no longer apply. [...]

Ok.

> [...] And as far as those macros go, there seem to be similar macros 
> already sprinkled around in various places, so I'm not sure how big 
> of a fallout we'd have if I just stick them into kernel.h.

That was a separate suggestion, outside the scope of this series.

Anyway, this v2 series looks good.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/