linux-kernel - Re: [char-misc-next] mei: add 9 series PCH mei device ids

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131205041913.GA4975@kroah.com>
Date:	Wed, 4 Dec 2013 20:19:13 -0800
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Tomas Winkler <tomas.winkler@...el.com>
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org
Subject: Re: [char-misc-next] mei: add 9 series PCH mei device ids

On Tue, Dec 03, 2013 at 01:01:29PM +0200, Tomas Winkler wrote:
> And Lynx Point H Refresh and Wildcat Point LP
> device ids.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> ---
>  drivers/misc/mei/hw-me-regs.h | 4 ++++
>  drivers/misc/mei/pci-me.c     | 4 +++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h
> index 6c0fde5..f83bc80 100644
> --- a/drivers/misc/mei/hw-me-regs.h
> +++ b/drivers/misc/mei/hw-me-regs.h
> @@ -110,8 +110,12 @@
>  #define MEI_DEV_ID_PPT_3      0x1DBA  /* Panther Point */
>  
>  #define MEI_DEV_ID_LPT        0x8C3A  /* Lynx Point */
> +#define MEI_DEV_ID_LPT_H      0x8C3A  /* Lynx Point H */

Why duplicate this #define?

And, now that you changed it, why keep the "old" one around, it's no
longer used anywhere else?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/