linux-kernel - Re: [PATCH] media: Add BCM2048 radio driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52A030BE.7040709@xs4all.nl>
Date:	Thu, 05 Dec 2013 08:52:30 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Pali Rohár <pali.rohar@...il.com>
CC:	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
	Eero Nurkkala <ext-eero.nurkkala@...ia.com>,
	Nils Faerber <nils.faerber@...nelconcepts.de>,
	Joni Lapilainen <joni.lapilainen@...il.com>,
	Ивайло Димитров 
	<freemangordon@....bg>
Subject: Re: [PATCH] media: Add BCM2048 radio driver

On 12/02/2013 09:51 PM, Pali Rohár wrote:
> On Monday 04 November 2013 12:39:44 Hans Verkuil wrote:
>> Hi Pali,
>>
>> On 10/26/2013 10:45 PM, Pali Rohár wrote:
>>> On Saturday 26 October 2013 22:22:09 Hans Verkuil wrote:
>>>>> Hans, so can it be added to drivers/staging/media tree?
>>>>
>>>> Yes, that is an option. It's up to you to decide what you
>>>> want. Note that if no cleanup work is done on the staging
>>>> driver for a long time, then it can be removed again.
>>>>
>>>> Regards,
>>>>
>>>>     Hans
>>>
>>> Ok, so if you can add it to staging tree. When driver will
>>> be in mainline other developers can look at it too. Now
>>> when driver is hidden, nobody know where to find it... You
>>> can see how upstream development for Nokia N900 HW going
>>> on: http://elinux.org/N900
>>
>> Please check my tree:
>>
>> http://git.linuxtv.org/hverkuil/media_tree.git/shortlog/refs/h
>> eads/bcm
>>
>> If you're OK, then I'll queue it for 3.14 (it's too late for
>> 3.13).
>>
>> Regards,
>>
>> 	Hans
> 
> Hi, sorry for late reply. I looked into your tree and difference 
> is that you only removed "linux/slab.h" include. So it it is not 
> needed, then it is OK.

I *added* slab.h :-)

Anyway, I've posted the pull request. Please note, if you want to avoid
having this driver be removed again in the future, then you (or someone else)
should work on addressing the issues in the TODO file I added.

Regards,

	Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/