linux-kernel - Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic into subfunction

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 5 Dec 2013 11:00:50 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Serban Constantinescu <serban.constantinescu@....com>
Cc:	gregkh@...uxfoundation.org, arve@...roid.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org,
	john.stultz@...aro.org, ccross@...roid.com, Dave.Butcher@....com,
	irogers@...gle.com, romlem@...roid.com
Subject: Re: [PATCH v1 1/9] staging: android: binder: Move some of the logic
 into subfunction

On Wed, Dec 04, 2013 at 06:09:33PM +0000, Serban Constantinescu wrote:
> +static void bc_dead_binder_done(struct binder_proc *proc,
> +		    struct binder_thread *thread, void __user *cookie)
> +{
> +	struct binder_work *w;
> +	struct binder_ref_death *death = NULL;
> +
> +	list_for_each_entry(w, &proc->delivered_death, entry) {
> +		struct binder_ref_death *tmp_death = container_of(w, struct binder_ref_death, work);

Put a blank line after the variable declaration block.  Also break it up
into two lines instead of having the lines be a million characters long.

	list_for_each_entry(w, &proc->delivered_death, entry) {
		struct binder_ref_death *tmp_death;

		tmp_death = container_of(w, struct binder_ref_death, work);

> +		if (tmp_death->cookie == cookie) {
> +			death = tmp_death;
> +			return;

Should be a break here.  This function wasn't tested.

> +		}
> +	}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/