linux-kernel - Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131205084909.GA25943@shlinux1.ap.freescale.net>
Date:	Thu, 5 Dec 2013 16:49:09 +0800
From:	Peter Chen <peter.chen@...escale.com>
To:	Daniel Tang <dt.tangr@...il.com>
CC:	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>, <linux-doc@...r.kernel.org>
Subject: Re: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding
 of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'

On Thu, Dec 05, 2013 at 04:44:13PM +1100, Daniel Tang wrote:
> Hi,
> 
> On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@...escale.com> wrote:
> 
> > 
> > lsi is vendor name, what are zevio and nspire?
> > Usually, the compatible string should be "vendor_name,soc_name-module_name"
> > 
> 
> Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.
> 

Please wrap the line to 80 characters.

The driver is written for the TI-Nspire, and you port this driver for
SoC Zevio platform? Since you use chipidea ip, we don't care the usb
module name at your platform, we only care the soc name which you are
running, it can detect the SoC platform at runtime.

At your dts patch, it still uses nspire-usb.
http://marc.info/?l=linux-usb&m=138614886720024&w=2

Peter

> If it's usually "vendor_name,soc_name-module_name", I'll fix up this patch with zevio instead of nspire (and it'll be more consistent with the other drivers).
> 
> >> - reg: Should contain registers location and length
> >> - interrupts: Should contain controller interrupt
> >> 
> >> @@ -11,7 +11,7 @@ Recommended properies:
> >> Examples:
> >> 		usb0: usb@...00000 {
> >> 			reg = <0xB0000000 0x1000>;
> >> -			compatible = "zevio,nspire-usb";
> >> +			compatible = "lsi,nspire-usb";
> >> 			interrupts = <8>;
> >> 			vbus-supply = <&vbus_reg>;
> >> 		};
> >> diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c
> >> index 517ce41..c5c2dde 100644
> >> --- a/drivers/usb/chipidea/ci_hdrc_nspire.c
> >> +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c
> >> @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev)
> >> }
> >> 
> >> static const struct of_device_id ci_hdrc_nspire_dt_ids[] = {
> >> -	{ .compatible = "zevio,nspire-usb", },
> >> +	{ .compatible = "lsi,nspire-usb", },
> >> 	{ /* sentinel */ }
> >> };
> >> 
> >> -- 
> >> 1.7.10.4
> >> 
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> >> the body of a message to majordomo@...r.kernel.org
> >> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >> 
> > 
> > -- 
> > 
> > Best Regards,
> > Peter Chen
> > 
> 
> Cheers,
> Daniel Tang

-- 

Best Regards,
Peter Chen

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/