linux-kernel - Re: [PATCH] regulator: gpio: Don't require a regulator-type property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131205113531.GN29268@sirena.org.uk>
Date:	Thu, 5 Dec 2013 11:35:31 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: gpio: Don't require a regulator-type property

On Thu, Dec 05, 2013 at 01:44:42AM +0100, Laurent Pinchart wrote:
> On Thursday 05 December 2013 00:31:55 Mark Brown wrote:

> > +	if (ret >= 0) {
> > +		if (!strncmp("voltage", regtype, 7))
> > +			config->type = REGULATOR_VOLTAGE;
> > +		else if (!strncmp("current", regtype, 7))
> > +			config->type = REGULATOR_CURRENT;

> Should we warn or error in case of an unsupported value ?

That's sensible, yes - this was just a straight change to make the
property optional.  Given that we've always accepted anything a warning
seems more appropriate otherwise we might break existing DTs with typos
or something.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)