linux-kernel - RE: [PATCH] x86/apic: Justification for disabling IO APIC before Local APIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3E5A0FA7E9CA944F9D5414FEC6C712205A595596@ORSMSX106.amr.corp.intel.com>
Date:	Thu, 5 Dec 2013 13:27:05 +0000
From:	"Yu, Fenghua" <fenghua.yu@...el.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Ingo Molnar <mingo@...e.hu>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel <linux-kernel@...r.kernel.org>, x86 <x86@...nel.org>
Subject: RE: [PATCH] x86/apic: Justification for disabling IO APIC before
 Local APIC

> From: Ingo Molnar [mailto:mingo.kernel.org@...il.com] On Behalf Of Ingo
> Molnar
> Sent: Thursday, December 05, 2013 12:55 AM
> 
> 
> * Fenghua Yu <fenghua.yu@...el.com> wrote:
> 
> > From: Fenghua Yu <fenghua.yu@...el.com>
> >
> > Since erratum AVR31 in "Intel Atom Processor C2000 Product Family
> > Specification Update" is published, I add a justification comment for
> > disabling IO APIC before Local APIC (commit 522e6646).
> >
> 
> Looks good to me, except that patch titles should start with verbs,
> i.e. something like:
> 
>   x86/apic/doc: Add justification for disabling IO APIC before Local
> APIC
> 
> Which makes for a much more fluid reading of shortlogs etc.
> 
> Unless you sentences without verbs.
>           ^-------------------------------------------like
> 
> ;-)
> 
> Thanks,
> 
> 	Ingo

Thank you very much for your comment, Ingo.

-Fenghua
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/