linux-kernel - Re: [PATCH] mm: do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1386254370-ui1ehq60-mutt-n-horiguchi@ah.jp.nec.com>
Date:	Thu, 05 Dec 2013 09:39:30 -0500
From:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>
To:	Jianguo Wu <wujianguo@...wei.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Johannes Weiner <hannes@...xchg.org>,
	Minchan Kim <minchan.kim@...il.com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, qiuxishi <qiuxishi@...wei.com>
Subject: Re: [PATCH] mm: do_mincore() cleanup

On Thu, Dec 05, 2013 at 04:52:52PM +0800, Jianguo Wu wrote:
> Two cleanups:
> 1. remove redundant codes for hugetlb pages.
> 2. end = pmd_addr_end(addr, end) restricts [addr, end) within PMD_SIZE,
>    this may increase do_mincore() calls, remove it.
> 
> Signed-off-by: Jianguo Wu <wujianguo@...wei.com>

Reviewed-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>

Thanks!

Naoya

> ---
>  mm/mincore.c |    7 -------
>  1 files changed, 0 insertions(+), 7 deletions(-)
> 
> diff --git a/mm/mincore.c b/mm/mincore.c
> index da2be56..1016233 100644
> --- a/mm/mincore.c
> +++ b/mm/mincore.c
> @@ -225,13 +225,6 @@ static long do_mincore(unsigned long addr, unsigned long pages, unsigned char *v
>  
>  	end = min(vma->vm_end, addr + (pages << PAGE_SHIFT));
>  
> -	if (is_vm_hugetlb_page(vma)) {
> -		mincore_hugetlb_page_range(vma, addr, end, vec);
> -		return (end - addr) >> PAGE_SHIFT;
> -	}
> -
> -	end = pmd_addr_end(addr, end);
> -
>  	if (is_vm_hugetlb_page(vma))
>  		mincore_hugetlb_page_range(vma, addr, end, vec);
>  	else
> -- 
> 1.7.1
> 
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/