linux-kernel - Re: [PATCH 1/2] usb: Use dev_is_pci() to check whether it is pci device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1312051009520.1311-100000@iolanthe.rowland.org>
Date:	Thu, 5 Dec 2013 10:10:16 -0500 (EST)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Yijing Wang <wangyijing@...wei.com>
cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Hanjun Guo <guohanjun@...wei.com>
Subject: Re: [PATCH 1/2] usb: Use dev_is_pci() to check whether it is pci
 device

On Thu, 5 Dec 2013, Yijing Wang wrote:

> Use PCI standard marco dev_is_pci() instead of directly compare
> pci_bus_type to check whether it is pci device.
> 
> Signed-off-by: Yijing Wang <wangyijing@...wei.com>
> ---
>  drivers/usb/host/ehci-dbg.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci-dbg.c b/drivers/usb/host/ehci-dbg.c
> index 4a9c2ed..0bb5e48 100644
> --- a/drivers/usb/host/ehci-dbg.c
> +++ b/drivers/usb/host/ehci-dbg.c
> @@ -818,7 +818,7 @@ static ssize_t fill_registers_buffer(struct debug_buffer *buf)
>  
>  #ifdef	CONFIG_PCI
>  	/* EHCI 0.96 and later may have "extended capabilities" */
> -	if (hcd->self.controller->bus == &pci_bus_type) {
> +	if (dev_is_pci(hcd->self.controller)) {
>  		struct pci_dev	*pdev;
>  		u32		offset, cap, cap2;
>  		unsigned	count = 256/4;

Acked-by: Alan Stern <stern@...land.harvard.edu>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/