linux-kernel - Re: lots of brief rcu stalls.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1386209910.30495.146.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 04 Dec 2013 18:18:30 -0800
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	paulmck@...ux.vnet.ibm.com
Cc:	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: lots of brief rcu stalls.

On Wed, 2013-12-04 at 16:16 -0800, Paul E. McKenney wrote:
> +	if (rdp->rsp == rcu_state &&
> +	    ULONG_CMP_GE(ACCESS_ONCE(jiffies), rdp->rsp->jiffies_resched)) {
> +		rdp->rsp->jiffies_resched += 5;
> +		resched_cpu(rdp->cpu);
> +	}
> +
>  	return 0;
>  }

jiffies should not need ACCESS_ONCE(), right ?

It is one of the few variables marked with volatile keyword.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/