lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 Dec 2013 13:51:51 -0800 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: linux-kernel@...r.kernel.org Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, stable@...r.kernel.org, Brian Foster <bfoster@...hat.com>, Dave Chinner <dchinner@...hat.com>, Gao feng <gaofeng@...fujitsu.com>, Dwight Engen <dwight.engen@...cle.com>, Ben Myers <bpm@....com>, Kees Cook <keescook@...gle.com> Subject: [PATCH 3.12 61/83] xfs: add capability check to free eofblocks ioctl 3.12-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dwight Engen <dwight.engen@...cle.com> commit 8c567a7fab6e086a0284eee2db82348521e7120c upstream. Check for CAP_SYS_ADMIN since the caller can truncate preallocated blocks from files they do not own nor have write access to. A more fine grained access check was considered: require the caller to specify their own uid/gid and to use inode_permission to check for write, but this would not catch the case of an inode not reachable via path traversal from the callers mount namespace. Add check for read-only filesystem to free eofblocks ioctl. Reviewed-by: Brian Foster <bfoster@...hat.com> Reviewed-by: Dave Chinner <dchinner@...hat.com> Reviewed-by: Gao feng <gaofeng@...fujitsu.com> Signed-off-by: Dwight Engen <dwight.engen@...cle.com> Signed-off-by: Ben Myers <bpm@....com> Cc: Kees Cook <keescook@...gle.com> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org> --- fs/xfs/xfs_ioctl.c | 6 ++++++ 1 file changed, 6 insertions(+) --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -1717,6 +1717,12 @@ xfs_file_ioctl( if (mp->m_flags & XFS_MOUNT_RDONLY) return -XFS_ERROR(EROFS); + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + if (mp->m_flags & XFS_MOUNT_RDONLY) + return -XFS_ERROR(EROFS); + if (copy_from_user(&eofb, arg, sizeof(eofb))) return -XFS_ERROR(EFAULT); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists