linux-kernel - Re: quilt 0.60 does not include CCed email without name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131206081816.GQ9578@alphonse.loria.fr>
Date:	Fri, 6 Dec 2013 09:18:17 +0100
From:	Martin Quinson <martin.quinson@...ia.fr>
To:	Christoph Lameter <cl@...ux.com>
Cc:	James Bottomley <James.Bottomley@...senPartnership.com>,
	Tejun Heo <tj@...nel.org>, akpm@...uxfoundation.org,
	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	Helge Deller <deller@....de>,
	Andreas Gruenbacher <agruen@...bit.com>
Subject: Re: quilt 0.60 does not include CCed email without name

On Thu, Dec 05, 2013 at 08:58:37PM +0000, Christoph Lameter wrote:
> > > You say this in the commit, but the linux-parisc list isn't cc'd on the
> > > email ...
> >
> > Weird my testoutput before the patchset was sent out shows that it
> > was included then :
> 
> Ok while the test output was done with quilt 0.50 the patch was actually
> send with quilt 0.60 from another system. quilt 0.60 skips all Cc:s that
> do not have a full name.
> 
> So Helge was included since it had a name
> 
> > Cc: Helge Deller <deller@....de>
> 
> but
> 
> > Cc: linux-parisc@...r.kernel.org
> 
> did not because no name was available.
> 
> Martin?

I'm sorry, I never use the quilt mail command myself. After a quick
investiguation of the git history, this bug seems to be caused by:
http://git.savannah.gnu.org/cgit/quilt.git/commit/?id=02f15444278eb3a854acae0192124153e0c6d9d4

I think that the last lines should be changed as follows (and same for
the one before):
- -e 's/^\('"$*"'\):\(.*<.*@.*>\)/Recipient-Cc:\2/Ip' \
+ -e 's/^\('"$*"'\):\(.*@.*\)/Recipient-Cc:\2/Ip' \

I'm CCing Andreas so that he can comment, and if nobody complains I'll
commit it to our git.

Many thanks for the detailed bug report,
Mt.

-- 
Simplicity does not precede complexity, but follows it.
   -- "Epigrams in Programming", by Alan J. Perlis of Yale University.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/