linux-kernel - Re: [PATCH] SFI: fix compilation warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Dec 2013 02:25:33 +0100
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	"Zheng, Lv" <lv.zheng@...el.com>
Cc:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	"Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] SFI: fix compilation warnings

On Friday, December 06, 2013 01:08:45 AM Zheng, Lv wrote:
> > From: Rafael J. Wysocki [mailto:rjw@...ysocki.net]
> > Sent: Friday, December 06, 2013 6:37 AM
> > 
> > On Thursday, December 05, 2013 07:26:37 PM Andy Shevchenko wrote:
> > > When build kernel with make W=1 we get the following compiler error.
> > >
> > > In file included from drivers/sfi/sfi_acpi.c:66:0:
> > > include/linux/sfi_acpi.h: In function ‘acpi_sfi_table_parse’:
> > > include/linux/sfi_acpi.h:72:2: error: implicit declaration of function ‘acpi_table_parse’ [-Werror=implicit-function-declaration]
> > >   if (!acpi_table_parse(signature, handler))
> > >   ^
> > >   cc1: some warnings being treated as errors
> > >
> > > The patch changes acpi/acpi.h inclusion to linux/acpi.h.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > 
> > OK
> > 
> > Lv, I'm dropping your patch cleaning up the inclusions, please sort that thing
> > out entirely for the next cycle.
> 
> No, I think Andy's patch is wrong.

His patch may be wrong, but the warning in his changelog surely is real. :-)

> This warning is existing before merging my fixes.
> 
> Either we fix this warning or leave it as is.
> 
> To fix it, you need to add 1 line in sfi_acpi.h rather than change the line.
> Let me post a fix for this.

Please do.  And I'm putting all ACPI header cleanups on hold until all warnings
of this kind have been fixed by them.  Otherwise doing those cleanups makes a
little sense in my opinion.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/