linux-kernel - Re: [PATCH 2/3] ASoC: fsl: imx-wm8962: Grant hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20131206143433.GH29268@sirena.org.uk>
Date:	Fri, 6 Dec 2013 14:34:33 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <b42378@...escale.com>
Cc:	lgirdwood@...il.com, alsa-devel@...a-project.org, tiwai@...e.de,
	perex@...ex.cz, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] ASoC: fsl: imx-wm8962: Grant hw_params/free()
 permission to control FLL

On Fri, Dec 06, 2013 at 05:47:43PM +0800, Nicolin Chen wrote:

> +static int imx_wm8962_enable_fll(struct snd_soc_dai *codec_dai, u32 sample_rate,
> +				snd_pcm_format_t sample_format)
> +{
> +	struct imx_priv *priv = &card_priv;
> +	struct device *dev = &priv->pdev->dev;
> +	struct imx_wm8962_data *data = platform_get_drvdata(priv->pdev);
> +	u32 freq, ret;
> +
> +	if (data->fll_lock)
> +		return 0;

Don't we need an actual lock to protect this?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)