linux-kernel - Re: [PATCH 03/10] net: stmmac: Use platform data tied with compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20131206.162633.125107323851595113.davem@davemloft.net>
Date:	Fri, 06 Dec 2013 16:26:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	wens@...e.org
Cc:	peppe.cavallaro@...com, netdev@...r.kernel.org,
	rob.herring@...xeda.com, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-sunxi@...glegroups.com, srinivas.kandagatla@...com,
	maxime.ripard@...e-electrons.com
Subject: Re: [PATCH 03/10] net: stmmac: Use platform data tied with
 compatible strings

From: Chen-Yu Tsai <wens@...e.org>
Date: Sat,  7 Dec 2013 01:29:36 +0800

> +	device = of_match_device(stmmac_dt_ids, &pdev->dev);
> +	if (!device)
> +		return -ENODEV;
> +
> +	if (device->data)
> +	    memcpy(plat, device->data, sizeof(*plat));
> +

Don't invent your own indentation using spaces, this memcpy()
call is not indented properly, it should be two TABs.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/