linux-kernel - Re: [PATCH net-next] ether_addr_equal: Optimize implementation, remove unused compare_ether

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20131206.163758.1360809557088338617.davem@davemloft.net>
Date:	Fri, 06 Dec 2013 16:37:58 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	netdev@...r.kernel.org, rob@...dley.net, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] ether_addr_equal: Optimize implementation,
 remove unused compare_ether_addr

From: Joe Perches <joe@...ches.com>
Date: Thu,  5 Dec 2013 14:54:38 -0800

> Add a new check for CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS to reduce
> the number of or's used in the ether_addr_equal comparison to very
> slightly improve function performance.
> 
> Simplify the ether_addr_equal_64bits implementation.
> Integrate and remove the zap_last_2bytes helper as it's now
> used only once.
> 
> Remove the now unused compare_ether_addr function.
> 
> Update the unaligned-memory-access documentation to remove the
> compare_ether_addr description and show how unaligned accesses
> could occur with ether_addr_equal.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/