linux-kernel - Re: [PATCH v5 0/2] watchdog: bcm281xx: Watchdog Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPdLdqnywgMagyxA34PUa14hSY5fJZK28_VtJMmDe-RdmAKD-g@mail.gmail.com>
Date:	Fri, 6 Dec 2013 14:23:21 -0800
From:	Markus Mayer <markus.mayer@...aro.org>
To:	Wim Van Sebroeck <wim@...ana.be>,
	Guenter Roeck <linux@...ck-us.net>,
	Christian Daudt <bcm@...thebug.org>
Cc:	Linaro Patches <patches@...aro.org>,
	Matt Porter <matt.porter@...aro.org>,
	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>,
	Linux Watchdog List <linux-watchdog@...r.kernel.org>,
	ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Markus Mayer <markus.mayer@...aro.org>
Subject: Re: [PATCH v5 0/2] watchdog: bcm281xx: Watchdog Driver

On 22 November 2013 14:56, Markus Mayer <markus.mayer@...aro.org> wrote:
> This is version 5 of the watchdog driver for the BCM281xx family of mobile
> SoCs.
>
> Changes since version 4:
> - Fixed whitespace issue in Kconfig "help" section
> - Rebased onto 3.13-rc1 (due to merge conflict in Makefile)
>
> Changes since version 3:
> - Removed #include <linux/miscdevice.h>
> - Added Reviewed-by:/Acked-by: Guenter Roeck
>
> Changes since version 2:
>
> - BCM_KONA_WDT_NAME: "bcm-kona-wdt" -> "bcm_kona_wdt"
> - Don't initialize static variable
> - Removed '{'/'}' from single-line statements
> - busy_count retains the maximum loop count of the longest loop rather
>   than an over-all maximum
> - Use seq_puts() in lieu of seq_printf() in 2 locations
> - Removed error message after devm_kzalloc()
> - Added MODULE_ALIAS
>
> Changes since version 1:
>
> - Added module name to "help" section in Kconfig A few cosmetic code
> - simplifications and fixes Removed most dev_info() calls and changed the
> - remaining ones to dev_dbg() Renamed SECWDOG_WD_LOAD_FLAG_MASK to
> - SECWDOG_WD_LOAD_FLAG Added some comments to secure_register_read() and
> - struct bcm_kona_wdt Added delay to secure_register_read() Reduced maximum
> - retry loop from 10000 to 1000 Introduced "busy_count" variable to count
> - how often secure_register_read() gets stalled; this is available through
> - debugfs Simplified secure_register_read() to return -ETIMEDOUT rather than
> - using a variable parameter to indicate a timeout error Got rid of all uses
> - of -EAGAIN Fixed return value check for debugfs_create_dir() Simplified
> - bcm_kona_wdt_debugfs_init() by getting rid of goto Created new generic
> - function bcm_kona_wdt_ctrl_reg_modify() The following functions now use
> - bcm_kona_wdt_ctrl_reg_modify():
>     - bcm_kona_wdt_set_resolution_reg() bcm_kona_wdt_set_timeout_reg()
>     - bcm_kona_wdt_stop()
> - Made bcm_kona_wdt_set_timeout_reg() more generic, so bcm_kona_wdt_start()
>   can use it Removed MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR)
>
> Markus Mayer (2):
>   watchdog: bcm281xx: Watchdog Driver
>   ARM: bcm281xx: watchdog configuration
>
>  arch/arm/configs/bcm_defconfig  |    3 +
>  drivers/watchdog/Kconfig        |   22 +++
>  drivers/watchdog/Makefile       |    1 +
>  drivers/watchdog/bcm_kona_wdt.c |  365 +++++++++++++++++++++++++++++++++++++++
>  4 files changed, 391 insertions(+)
>  create mode 100644 drivers/watchdog/bcm_kona_wdt.c
>
> --
> 1.7.9.5

Hi,

This series seems approved and ready to go. I just wanted to
double-check that my understanding is correct and that it will be
queued for 3.14. However, if there is anything you need from me,
please let me know.

Thanks,
-Markus

-- 
Markus Mayer
Broadcom Landing Team
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/