linux-kernel - Re: [PATCH v10 1/3] aerdrv: Trace Event for AER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20131207174542.GB4183@pd.tnic>
Date:	Sat, 7 Dec 2013 18:45:42 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Ethan Zhao <ethan.kernel@...il.com>
Cc:	rui wang <ruiv.wang@...il.com>, Lance Ortiz <lance.ortiz@...com>,
	Bjorn Helgaas <bhelgaas@...gle.com>, lance_ortiz@...mail.com,
	jiang.liu@...el.com, tony.luck@...el.com, rostedt@...dmis.org,
	mchehab@...hat.com, linux-acpi@...r.kernel.org,
	linux-pci <linux-pci@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>, gong.chen@...el.com
Subject: Re: [PATCH v10 1/3] aerdrv: Trace Event for AER

On Fri, Dec 06, 2013 at 11:11:07PM +0800, Ethan Zhao wrote:
> > @@ -63,10 +63,10 @@ TRACE_EVENT(aer_event,
> >
> >         TP_printk("%s PCIe Bus Error: severity=%s, %s\n",
> >                 __get_str(dev_name),
> > -               __entry->severity == HW_EVENT_ERR_CORRECTED ? "Corrected" :
> > -                       __entry->severity == HW_EVENT_ERR_FATAL ?
> > +               __entry->severity == AER_CORRECTABLE ? "Corrected" :
> > +                       __entry->severity == AER_FATAL ?
> >                         "Fatal" : "Uncorrected",
> 
> Why not             "Fatal" : "Non-fatal",   ?  per the PCIe spec,
> 'Fatal' and 'Non-fatal' are sub-category of "
> Uncorrected". But here "Uncorrected" means "Non-fatal".

... and just to denote that, it'll probably be best to say:

		__entry->severity == AER_CORRECTABLE ? "Corrected" :
			__entry->severity == AER_FATAL ?
			   "Fatal" : "Uncorrected, non-fatal"

right?

Btw, Rui, you patch is whitespace-damaged so next time please try
sending from a real mail client which doesn't mangle whitespace and not
from the gmail web interface. Sending the patch to yourself and trying
to apply it is always a good test for that.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/